Has a lot of great potential, but every key I set for smoke seems to get in the way of something on controller. Even inexplicable ones. like setting L on keyboard means clicking right stick on controller or setting caps lock means left stick on controller. If there was a KeyboardOnly option for smoke that'd make this mod essential for modded gameplay, but as it stands I keep triggering smoke when I try to do native vehicle controls.
This mod looks really feature rich and promising! Unfortunately, I still have to use LeFixSimpleFuel because it allows up to 99 custom gas stations. I have 63 gas stations total in my game, because I use mod maps like Liberty City and San Fierro/Las Venturas. An option to have more custom gas stations would be really appreciated, especially if it was in its own separate INI file. I'd also love an option to import stations from other mods, like LeFixSimpleFuel, to make changing to your mod much simpler and easier. If that were added, I'd switch to this mod in a heartbeat. Great work overall!
[fwTimer.cpp] Found rage::fwTimer::sm_bUserPause
[scrThread.cpp] Found rage::scrThread::sm_Threads
[scrThread.cpp] Found rage::scrThread::_sm_cwThreads
[scrThread.cpp] Found rage::scrThread::sm_Stacks
[scrThread.cpp] Found rage::scrThread::_sm_cwStacks
[ScriptRoutineTracer.cpp] Hooked rage::scrThread::_RunInstr
[ScriptRoutineTracer.cpp] Found ENTER instruction byte to trap in rage::scrThread::_RunInstr
[ScriptRoutineTracer.cpp] Found LEAVE instruction byte to trap in rage::scrThread::_RunInstr
[Hwnd.cpp] Found hWnd
[Main.cpp] Hooked WndProc
[Main.cpp] Hooked rage::scrThread::Update
[Main.cpp] Swap Chain was invalid, aborting!
Doesn't seem to be working for me either, also on 2944. This is my scriptviewerlog.txt:
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/fwTimer.cpp] Found rage::fwTimer::sm_bUserPause
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::sm_Threads
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::_sm_cwThreads
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::sm_Stacks
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::_sm_cwStacks
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/Hwnd.cpp] Found hWnd
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Hooked rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Found ENTER instruction byte to trap in rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Found LEAVE instruction byte to trap in rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Hooked WndProc
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Hooked rage::scrThread::Update
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Swap Chain was invalid, aborting!
Great work on the rewrite, performance is noticeably better! Shift and Z is a pretty awful key combo for the menu though, I unintentionally open the menu every time I try to expand the minimap while sprinting. If the menu key combo could be changed in the INI, I'd really appreciate that feature!
Spoke too soon, happens on 0.7.3 as well. Again, totally default settings and files. Here's the 0.7.3 error:
[ERROR] [7/4/2023 12:16:50 PM] Object reference not set to an instance of an object.
[ERROR] [7/4/2023 12:16:50 PM] at PropertyManager.Events.AliveParkings.<>c__DisplayClass0_0.<.ctor>b__4()
at PropertyManager.Events.AliveFeature.<Update>b__30_0()
at PropertyManager.Thread2.<>c.<.ctor>b__0_0(Object sender, EventArgs args)
@houaryou The latest version is crashing on me, I can't seem to get it to work. I get a Null exception every time the game starts up, which gets recorded in PropertyManagerError.log. Here's the most recent error output:
######################## Exception Start ########################
# Date: 7/4/2023 11:45:13 AM
# Custom Message: None
# Message: Value cannot be null.
Parameter name: key
# StackTrace: at System.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
at GTA.ScriptSettings.GetValue[T](String section, String name, T defaultvalue) in D:\a\scripthookvdotnet\scripthookvdotnet\source\scripting_v3\GTA\ScriptSettings.cs:line 188
at PropertyManager.SettingsManager.GetValueWithFallback(String defaultSection, String key, String defaultValue, Property property)
at PropertyManager.SettingsManager.isShowerFeatureEnabled(Property property)
at PropertyManager.Property..ctor(String name, Vector3 location, String dlc)
at PropertyManager.PropertyBuilders.ModernCasualApartment.Build(String dlc)
at PropertyManager.PropertyManager.RegisterDlcs()
at PropertyManager.PropertyManager..ctor()
# Source: mscorlib
# Helplink:
# TargetSite: Void ThrowArgumentNullException(System.ExceptionArgument)
# TargetSite DeclaringType: System.ThrowHelper
# TargetSite Name: ThrowArgumentNullException
# TargetSite IsStatic: True
# TargetSite IsPublic: False
######################### Exception End #########################
Glad to see the mod updated to SHVDN3! Have any of the above issues I mentioned been addressed?
Has a lot of great potential, but every key I set for smoke seems to get in the way of something on controller. Even inexplicable ones. like setting L on keyboard means clicking right stick on controller or setting caps lock means left stick on controller. If there was a KeyboardOnly option for smoke that'd make this mod essential for modded gameplay, but as it stands I keep triggering smoke when I try to do native vehicle controls.
This mod looks really feature rich and promising! Unfortunately, I still have to use LeFixSimpleFuel because it allows up to 99 custom gas stations. I have 63 gas stations total in my game, because I use mod maps like Liberty City and San Fierro/Las Venturas. An option to have more custom gas stations would be really appreciated, especially if it was in its own separate INI file. I'd also love an option to import stations from other mods, like LeFixSimpleFuel, to make changing to your mod much simpler and easier. If that were added, I'd switch to this mod in a heartbeat. Great work overall!
I have many, many other mods installed. I'll link screenshots of my ASIs and scripts folder. I'm on DX11, you have to be to use NVE. The game is running in fullscreen. Here's my ASILoader.log:https://pastebin.com/trMJrNTX
here's my scripthookv.log: https://pastebin.com/mMXuqgsM
and here are my game files:https://imgur.com/a/R0h4Hj2
Thanks for looking into this!
@pongo1231 Same problem, unfortunately.
[fwTimer.cpp] Found rage::fwTimer::sm_bUserPause
[scrThread.cpp] Found rage::scrThread::sm_Threads
[scrThread.cpp] Found rage::scrThread::_sm_cwThreads
[scrThread.cpp] Found rage::scrThread::sm_Stacks
[scrThread.cpp] Found rage::scrThread::_sm_cwStacks
[ScriptRoutineTracer.cpp] Hooked rage::scrThread::_RunInstr
[ScriptRoutineTracer.cpp] Found ENTER instruction byte to trap in rage::scrThread::_RunInstr
[ScriptRoutineTracer.cpp] Found LEAVE instruction byte to trap in rage::scrThread::_RunInstr
[Hwnd.cpp] Found hWnd
[Main.cpp] Hooked WndProc
[Main.cpp] Hooked rage::scrThread::Update
[Main.cpp] Swap Chain was invalid, aborting!
Doesn't seem to be working for me either, also on 2944. This is my scriptviewerlog.txt:
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/fwTimer.cpp] Found rage::fwTimer::sm_bUserPause
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::sm_Threads
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::_sm_cwThreads
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::sm_Stacks
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Lib/scrThread.cpp] Found rage::scrThread::_sm_cwStacks
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/Hwnd.cpp] Found hWnd
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Hooked rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Found ENTER instruction byte to trap in rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Memory/ScriptRoutineTracer.cpp] Found LEAVE instruction byte to trap in rage::scrThread::_RunInstr
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Hooked WndProc
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Hooked rage::scrThread::Update
[z:/media/hdd/projects/V.ScriptViewer/ScriptViewer/Main.cpp] Swap Chain was invalid, aborting!
Great work on the rewrite, performance is noticeably better! Shift and Z is a pretty awful key combo for the menu though, I unintentionally open the menu every time I try to expand the minimap while sprinting. If the menu key combo could be changed in the INI, I'd really appreciate that feature!
Spoke too soon, happens on 0.7.3 as well. Again, totally default settings and files. Here's the 0.7.3 error:
[ERROR] [7/4/2023 12:16:50 PM] Object reference not set to an instance of an object.
[ERROR] [7/4/2023 12:16:50 PM] at PropertyManager.Events.AliveParkings.<>c__DisplayClass0_0.<.ctor>b__4()
at PropertyManager.Events.AliveFeature.<Update>b__30_0()
at PropertyManager.Thread2.<>c.<.ctor>b__0_0(Object sender, EventArgs args)
I've been using the default settings file, no changes. The error happens on 0.8 to 0.8.1.0b, but doesn't happen when I downgrade to 0.7.3...
@houaryou The latest version is crashing on me, I can't seem to get it to work. I get a Null exception every time the game starts up, which gets recorded in PropertyManagerError.log. Here's the most recent error output:
######################## Exception Start ########################
# Date: 7/4/2023 11:45:13 AM
# Custom Message: None
# Message: Value cannot be null.
Parameter name: key
# StackTrace: at System.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
at GTA.ScriptSettings.GetValue[T](String section, String name, T defaultvalue) in D:\a\scripthookvdotnet\scripthookvdotnet\source\scripting_v3\GTA\ScriptSettings.cs:line 188
at PropertyManager.SettingsManager.GetValueWithFallback(String defaultSection, String key, String defaultValue, Property property)
at PropertyManager.SettingsManager.isShowerFeatureEnabled(Property property)
at PropertyManager.Property..ctor(String name, Vector3 location, String dlc)
at PropertyManager.PropertyBuilders.ModernCasualApartment.Build(String dlc)
at PropertyManager.PropertyManager.RegisterDlcs()
at PropertyManager.PropertyManager..ctor()
# Source: mscorlib
# Helplink:
# TargetSite: Void ThrowArgumentNullException(System.ExceptionArgument)
# TargetSite DeclaringType: System.ThrowHelper
# TargetSite Name: ThrowArgumentNullException
# TargetSite IsStatic: True
# TargetSite IsPublic: False
######################### Exception End #########################